Add TbV log clustering by scene (i.e. spatial location). #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senselessdev1
changed the title
| """ | ||
|
|
||
|
|
||
| ATX_CLUSTERS = { |
There was a problem hiding this comment.
Suggested change
| ATX_CLUSTERS = { | |
| ATX_CLUSTERS: Final[Dict[int, Tuple[str, ...]]] = { |
My suggestion is to make these map from int to tuples of strs since they're static data.
There was a problem hiding this comment.
Good call @benjaminrwilson. Just updated to make this change.
There was a problem hiding this comment.
Actually, looks like mypy interprets 1: ("mystring") as int: str instead of int: Tuple[str,...].
src/av2/datasets/tbv/scene_clusters.py:20: error: Dict entry 2 has incompatible type "int": "str"; expected "int": "Tuple[str, ...]"
src/av2/datasets/tbv/scene_clusters.py:21: error: Dict entry 3 has incompatible type "int": "str"; expected "int": "Tuple[str, ...]"
src/av2/datasets/tbv/scene_clusters.py:26: error: Dict entry 5 has incompatible type "int": "str"; expected "int": "Tuple[str, ...]"
I think I'll have to revert it.
There was a problem hiding this comment.
Wouldn't we need to add a comma for a tuple literal?
E.g., 1: ("mystring",)
There was a problem hiding this comment.
I see, yeah. I think that's a bit uglier though. I would prefer we keep it as list.
benjaminrwilson
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Some users are interested in clustering TbV logs by spatial location, to identify before/after logs. This PR adds annotation of which logs are clustered together, in which cities. Each log in each cluster shares some visual overlap.
Testing
In order to ensure this PR works as intended, it is:
Compliance with Standards
As the author, I certify that this PR conforms to the following standards: